On Tue, Sep 22, 2020 at 09:54:58AM -0400, Nitesh Narayan Lal wrote: > >> If min_vecs > num_housekeeping, for example: > >> > >> /* PCI MSI/MSIx support */ > >> #define XGBE_MSI_BASE_COUNT 4 > >> #define XGBE_MSI_MIN_COUNT (XGBE_MSI_BASE_COUNT + 1) > >> > >> Then the protection fails. > > Right, I was ignoring that case. > > > >> How about reducing max_vecs down to min_vecs, if min_vecs > > >> num_housekeeping ? > > Yes, I think this makes sense. > > I will wait a bit to see if anyone else has any other comment and will post > > the next version then. > > > > Are there any other comments/concerns on this patch that I need to address in > the next posting? No objection from me, I don't know much about this area anyway. > -- > Nitesh >