On Thu, Sep 17, 2020 at 11:28:03PM +0200, Gustavo Pimentel wrote: > Fixes warning given by executing "make C=2 drivers/pci/" > > Sparse output: > CHECK drivers/pci/controller/dwc/pcie-designware.c > drivers/pci/controller/dwc/pcie-designware.c:432:52: warning: > cast truncates bits from constant value (ffffffff7fffffff becomes > 7fffffff) > > Reported-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > Cc: Joao Pinto <jpinto@xxxxxxxxxxxx> > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@xxxxxxxxxxxx> > --- > drivers/pci/controller/dwc/pcie-designware.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c > index 3c3a4d1..dcb7108 100644 > --- a/drivers/pci/controller/dwc/pcie-designware.c > +++ b/drivers/pci/controller/dwc/pcie-designware.c > @@ -429,7 +429,7 @@ void dw_pcie_disable_atu(struct dw_pcie *pci, int index, > } > > dw_pcie_writel_dbi(pci, PCIE_ATU_VIEWPORT, region | index); > - dw_pcie_writel_dbi(pci, PCIE_ATU_CR2, (u32)~PCIE_ATU_ENABLE); > + dw_pcie_writel_dbi(pci, PCIE_ATU_CR2, (u32)~0 & ~PCIE_ATU_ENABLE); But this cure is worse than the disease. If this is the only way to fix the warning, I think I'd rather see the warning ;) I'm hopeful there's a nicer way, but I'm not a language lawyer. > } > > int dw_pcie_wait_for_link(struct dw_pcie *pci) > -- > 2.7.4 >
