On Wed, Sep 16, 2020 at 05:59:24PM +1000, Benjamin Herrenschmidt wrote: > On Tue, 2020-09-15 at 20:40 -0300, Jason Gunthorpe wrote: > > > Like I said, the case where the driver can't self test probably > > doesn't intersect with the ARM implementations that can't do write > > combining, and if it did, the users probably run the out of tree > > driver that has the hacky stuff to make it use DEVICE_GRE. > > Ok. So you are saying to go for it and ignore that Mellanox case then ? > :-) Regarding Mellanox, as I wrote it in the beginning of this thread, you can ignore mlx5 driver. https://lore.kernel.org/linux-pci/20200910105419.GH421756@unreal/ Thanks