On Tue, Sep 8, 2020 at 9:10 PM Jianjun Wang <jianjun.wang@xxxxxxxxxxxx> wrote: > > On Tue, 2020-09-08 at 13:50 -0600, Rob Herring wrote: > > On Mon, 07 Sep 2020 20:08:50 +0800, Jianjun Wang wrote: > > > Add YAML schemas documentation for Gen3 PCIe controller on > > > MediaTek SoCs. > > > > > > Acked-by: Ryder Lee <ryder.lee@xxxxxxxxxxxx> > > > Signed-off-by: Jianjun Wang <jianjun.wang@xxxxxxxxxxxx> > > > --- > > > .../bindings/pci/mediatek-pcie-gen3.yaml | 158 ++++++++++++++++++ > > > 1 file changed, 158 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.example.dts:55.56-59.19: Warning (pci_device_reg): /example-0/bus/pcie@11230000/legacy-interrupt-controller: missing PCI reg property > > > > > > See https://patchwork.ozlabs.org/patch/1359119 > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure dt-schema is up to date: > > > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > > > Please check and re-submit. > > > > Yes, I have already found this warning message, but I'm confused with > how to add this reg property, since the interrupt-controller has inherit > the pci device type but does not have its own registers. > > Could you please tell me how to fix this error, or which docs can I > refer to? Actually, disregard this. We need to fix dtc for this case. Rob