On Tue, Sep 08, 2020 at 09:47:21PM +0800, Hongtao Wu wrote: > From: Billows Wu <billows.wu@xxxxxxxxxx> > > This series adds PCIe controller driver for Unisoc SoCs. > This controller is based on DesignWare PCIe IP. > > Signed-off-by: Billows Wu <billows.wu@xxxxxxxxxx> Last signed-off must be from developer submitting the patch, i.e., Hongtao Wu; see https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst#n560 > +config PCIE_SPRD > + tristate "Unisoc PCIe controller - RC mode" s/RC mode/Host mode/ to follow convention of other drivers. > + depends on ARCH_SPRD || COMPILE_TEST > + depends on PCI_MSI_IRQ_DOMAIN > + select PCIE_DW_HOST > + help > + Unisoc PCIe controller uses the Designware core. It can be configured s/Designware/DesignWare/ > + as an Endpoint (EP) or a Root complex (RC). In order to enable RC > + mode, PCIE_SPRD must be selected. > + Say Y or M here if you want to PCIe RC controller support on Unisoc > + SoCs. > + dev_dbg(&pdev->dev, dev_dbg(dev, ... > + "%2d:reg[0x%8x] mask[0x%8x] val[0x%8x] result[0x%8x]\n", > + i, reg, mask, val, tmp_val);
