Re: [PATCH] PCI: keystone: Enable compile-testing on !ARM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Sep 06, 2020 at 02:19:44PM +0200, Krzysztof Kozlowski wrote:
> On Fri, 4 Sep 2020 at 20:56, Alex Dewar <alex.dewar90@xxxxxxxxx> wrote:
> >
> > Currently the Keystone driver can only be compile-tested on ARM, but
> > this restriction seems unnecessary. Get rid of it to increase test
> > coverage.
> >
> > Build-tested on x86 with allyesconfig.
> 
> You should at least build it on x86_64, powerpc and MIPS. These are
> widely available (e.g. in most of distros, or here:
> https://mirrors.edge.kernel.org/pub/tools/crosstool/). Useful is also
> riscv and sh (specially sh lacks certain headers/features).

Good suggestion. I've built it on x86, ppc, mips and riscv. sh wouldn't
build because of some kbuild dependency, rather than a compiler error.
I'll send a v2 with an updated commit message.

> 
> Best regards,
> Krzysztof



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux