On Wed, Aug 26 2020 at 21:21, Marc Zyngier wrote: > On Wed, 26 Aug 2020 12:16:47 +0100, > Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote: >> -void pci_msi_set_desc(msi_alloc_info_t *arg, struct msi_desc *desc) >> -{ >> - arg->desc = desc; >> - arg->hwirq = pci_msi_domain_calc_hwirq(desc); >> -} >> -EXPORT_SYMBOL_GPL(pci_msi_set_desc); > > I think that at this stage, pci_msi_domain_calc_hwirq() can be made > static, as it was only ever exported for this call site. Nice cleanup! Doh indeed. Let me fix that.