Re: [PATCH 3/5] arm64: dts: renesas: r8a774a1: Add PCIe EP nodes

Sergei Shtylyov <sergei.shtylyov@xxxxxxxxx> · Tue, 18 Aug 2020 11:38:40 +0300

On 18.08.2020 10:23, Lad, Prabhakar wrote:

[...]
Add PCIe EP nodes to R8A774A1 (RZ/G2M) SoC dtsi.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
---
   arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 38 +++++++++++++++++++++++
   1 file changed, 38 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
index a603d947970e..50e9ed16a36d 100644
--- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
@@ -2369,6 +2369,44 @@
                       status = "disabled";
               };

+             pciec0_ep: pcie_ep@fe000000 {

     Hyphens are preferred over underscores in the node/prop names.

[...]
+                pciec1_ep: pcie_ep@ee800000 {

     Ditto, should be "pci-ep@ee800000".

My bad will fix that in v2.

   Sorry, I meant to type "pcie-ep@ee800000".

Cheers,
Prabhakar

MBR, Sergei






