Hi Shiju, On 22/07/2020 13:50, Andy Shevchenko wrote: > On Wed, Jul 22, 2020 at 12:34:23PM +0000, Shiju Jose wrote: >>>> Co-developed-by: James Morse <james.morse@xxxxxxx> >>> >>> Co-developed-by: is going _in conjunction with_ SoB tag which is missing >>> here. >> This tag was added as per instruction from Rafael. >> I was told that I cannot add SoB tag for others unless specifically given. >> Probably I will leave it with Rafael/James to help on this SoB tag >> as Rafael was ok to merge this patch. > > I think it's a misunderstanding somewhere. According to [1]: > "Since Co-developed-by: denotes authorship, every Co-developed-by: must be > immediately followed by a Signed-off-by: of the associated co-author." > > It means either both or none. > > [1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html Sorry for this mess! My intention was to summarise my suggestion in the form of a patch, I wasn't expecting you to pick it up. (and I didn't post it because there was ongoing discussion on the second part) I'll repost this with the Co-Developed-by stuff. You'll need to re-post it with the series, you'll need to move your Signed-Off-By to be last when you do that. Thanks, James