On Wed, Jul 29, 2020 at 02:24:16PM -0500, Bjorn Helgaas wrote: > On Wed, Jul 29, 2020 at 08:26:20AM +0200, Krzysztof Kozlowski wrote: > > Fix W=1 compile warnings (invalid kerneldoc): > > > > drivers/pci/vc.c:188: warning: Excess function parameter 'name' description in 'pci_vc_do_save_buffer' > > > > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > This looks great, but would you mind doing all the ones in drivers/pci > at the same time? When I tested this, I also found the following, and > I don't think it's worth doing them one at a time: > > $ make W=1 drivers/pci/ > drivers/pci/hotplug/acpi_pcihp.c:69: warning: Function parameter or member 'pdev' not described in 'acpi_get_hp_hw_control_from_firmware' > drivers/pci/hotplug/acpi_pcihp.c:69: warning: Excess function parameter 'dev' description in 'acpi_get_hp_hw_control_from_firmware' > drivers/pci/hotplug/acpi_pcihp.c:199: warning: Function parameter or member 'handle' not described in 'acpi_pci_detect_ejectable' > drivers/pci/endpoint/functions/pci-epf-test.c:189: warning: Function parameter or member 'epf_test' not described in 'pci_epf_test_clean_dma_chan' > drivers/pci/endpoint/functions/pci-epf-test.c:189: warning: Excess function parameter 'epf' description in 'pci_epf_test_clean_dma_chan' > drivers/pci/endpoint/pci-ep-cfs.c:17: warning: Function parameter or member 'functions_idr' not described in 'DEFINE_IDR' > drivers/pci/endpoint/pci-epc-core.c:18: warning: cannot understand function prototype: 'struct class *pci_epc_class; ' > drivers/pci/endpoint/pci-epf-core.c:18: warning: Function parameter or member 'pci_epf_mutex' not described in 'DEFINE_MUTEX' > drivers/pci/endpoint/pci-epf-core.c:80: warning: Function parameter or member 'epf' not described in 'pci_epf_free_space' > drivers/pci/endpoint/pci-epf-core.c:107: warning: Function parameter or member 'epf' not described in 'pci_epf_alloc_space' > drivers/pci/endpoint/pci-epc-mem.c:16: warning: Incorrect use of kernel-doc format: * pci_epc_mem_get_order() - determine the allocation order of a memory size > drivers/pci/endpoint/pci-epc-mem.c:24: warning: Function parameter or member 'mem' not described in 'pci_epc_mem_get_order' > drivers/pci/endpoint/pci-epc-mem.c:24: warning: Function parameter or member 'size' not described in 'pci_epc_mem_get_order' > drivers/pci/setup-bus.c:62: warning: Function parameter or member 'min_align' not described in 'add_to_list' > drivers/pci/vc.c:188: warning: Excess function parameter 'name' description in 'pci_vc_do_save_buffer' > drivers/pci/of.c:262: warning: Function parameter or member 'ib_resources' not described in 'devm_of_pci_get_host_bridge_resources' > drivers/pci/ats.c:196: warning: Function parameter or member 'pdev' not described in 'pci_enable_pri' > drivers/pci/ats.c:196: warning: Function parameter or member 'reqs' not described in 'pci_enable_pri' > drivers/pci/pci-pf-stub.c:20: warning: cannot understand function prototype: 'const struct pci_device_id pci_pf_stub_whitelist[] = ' Sure, I can work on more of them. Somehow this one got enabled on my build (usually it does not contain PCI) and I decided to fix it. It's a compiler warning so still even one-at-a-time brings us closer to clean builds. Best regards, Krzysztof
