On Mon, Jul 06, 2020 at 09:52:34PM +0800, Wei Yongjun wrote:
> sparse report build warning as follows:
>
> drivers/pci/controller/pci-hyperv.c:941:5: warning:
> symbol 'hv_read_config_block' was not declared. Should it be static?
> drivers/pci/controller/pci-hyperv.c:1021:5: warning:
> symbol 'hv_write_config_block' was not declared. Should it be static?
> drivers/pci/controller/pci-hyperv.c:1090:5: warning:
> symbol 'hv_register_block_invalidate' was not declared. Should it be static?
>
> Those functions are not used outside of this file, so mark them static.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> ---
> drivers/pci/controller/pci-hyperv.c | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
Applied to pci/hv, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> index bf40ff09c99d..5c496b93cea9 100644
> --- a/drivers/pci/controller/pci-hyperv.c
> +++ b/drivers/pci/controller/pci-hyperv.c
> @@ -938,8 +938,9 @@ static void hv_pci_read_config_compl(void *context, struct pci_response *resp,
> *
> * Return: 0 on success, -errno on failure
> */
> -int hv_read_config_block(struct pci_dev *pdev, void *buf, unsigned int len,
> - unsigned int block_id, unsigned int *bytes_returned)
> +static int hv_read_config_block(struct pci_dev *pdev, void *buf,
> + unsigned int len, unsigned int block_id,
> + unsigned int *bytes_returned)
> {
> struct hv_pcibus_device *hbus =
> container_of(pdev->bus->sysdata, struct hv_pcibus_device,
> @@ -1018,8 +1019,8 @@ static void hv_pci_write_config_compl(void *context, struct pci_response *resp,
> *
> * Return: 0 on success, -errno on failure
> */
> -int hv_write_config_block(struct pci_dev *pdev, void *buf, unsigned int len,
> - unsigned int block_id)
> +static int hv_write_config_block(struct pci_dev *pdev, void *buf,
> + unsigned int len, unsigned int block_id)
> {
> struct hv_pcibus_device *hbus =
> container_of(pdev->bus->sysdata, struct hv_pcibus_device,
> @@ -1087,9 +1088,9 @@ int hv_write_config_block(struct pci_dev *pdev, void *buf, unsigned int len,
> *
> * Return: 0 on success, -errno on failure
> */
> -int hv_register_block_invalidate(struct pci_dev *pdev, void *context,
> - void (*block_invalidate)(void *context,
> - u64 block_mask))
> +static int hv_register_block_invalidate(struct pci_dev *pdev, void *context,
> + void (*block_invalidate)(void *context,
> + u64 block_mask))
> {
> struct hv_pcibus_device *hbus =
> container_of(pdev->bus->sysdata, struct hv_pcibus_device,
>
