On Mon, Jul 27, 2020 at 11:21 AM Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > > On Mon, Jul 27, 2020 at 10:21:42AM -0600, Rob Herring wrote: > > On Tue, Jun 23, 2020 at 8:55 AM Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > > > > > > From: Thierry Reding <treding@xxxxxxxxxx> > > > > > > The Tegra PCI controller driver doesn't need to control the PLL power > > > supplies directly, but rather uses the pads provided by the XUSB pad > > > controller, which in turn is responsible for supplying power to the > > > PLLs. > > > > > > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> > > > --- > > > drivers/pci/controller/pci-tegra.c | 10 ++-------- > > > 1 file changed, 2 insertions(+), 8 deletions(-) > > > > What's going to happen here with a new dtb and an old kernel? Is it > > going to error out due to missing supplies? > > It's not going to error out but fallback to the "dummy" regulator, so > this should be fine from a forwards-compatibility point of view. Though > I didn't think we technically cared about that direction very much. AIUI, SUSE ships newer DTs with stable kernels. Of course, the dtb's shouldn't really come from the OS vendors, but you wouldn't want a newer firmware (w/ dtb) to break your OS either. In any case, Reviewed-by: Rob Herring <robh@xxxxxxxxxx> Rob
