Re: [PATCH][next] PCI: imx6: Use fallthrough pseudo-keyword

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bjorn,

On 7/16/20 17:06, Bjorn Helgaas wrote:
> On Thu, Jul 16, 2020 at 04:10:52PM -0500, Gustavo A. R. Silva wrote:
>> Replace the existing /* fall through */ comments and its variants with
>> the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
>> fall-through markings when it is the case.
>>
>> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> 
> Hi Gustavo,
> 
> I'm certainly fine with these patches, and thanks for doing them!
> 
> And thanks for providing a link to the rationale.  But the URL
> contains "latest", so I think it may break if deprecated.rst or the
> section is ever renamed.
> 
> I think I would prefer if we could reference the current text, e.g.,
> via
> 
>   https://www.kernel.org/doc/html/v5.7-rc7/process/deprecated.html#implicit-switch-case-fall-through
> 

I already sent v2 with a URL to proper documentation for Linux v5.7:

https://lore.kernel.org/lkml/20200722031903.GA3711@embeddedor/

> (The v5.7 doc would be better but doesn't seem to be generated yet; I
> pinged the helpdesk about that.)
> 

Thanks for doing that. I wasn't aware that one could ask helpdesk about this.

--
Gustavo




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux