"Saheed O. Bolarinwa" <refactormyself@xxxxxxxxx> wrote: > From: Bolarinwa Olayemi Saheed <refactormyself@xxxxxxxxx> > > On failure pcie_capability_read_dword() sets it's last parameter, val > to 0. However, with Patch 14/14, it is possible that val is set to ~0 on > failure. This would introduce a bug because (x & x) == (~0 & x). > > This bug can be avoided without changing the function's behaviour if the > return value of pcie_capability_read_dword is checked to confirm success. > > Check the return value of pcie_capability_read_dword() to ensure success. > > Suggested-by: Bjorn Helgaas <bjorn@xxxxxxxxxxx> > Signed-off-by: Bolarinwa Olayemi Saheed <refactormyself@xxxxxxxxx> Patch applied to wireless-drivers-next.git, thanks. 9018fd7f2a73 iwlegacy: Check the return value of pcie_capability_read_*() -- https://patchwork.kernel.org/patch/11660739/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
