On Tue, Jul 14, 2020 at 02:02:41PM -0500, Bjorn Helgaas wrote:
> On Tue, Jul 14, 2020 at 12:38:01PM +0300, Andy Shevchenko wrote:
> > On Mon, Jul 13, 2020 at 04:02:01PM -0500, Bjorn Helgaas wrote:
> > > On Mon, Jul 13, 2020 at 10:44:36PM +0300, Andy Shevchenko wrote:
> > > > Switch the platform code to use x86_id_table and accompanying API
> > > > instead of custom comparison against x86 CPU model.
...
> > > > - case INTEL_MID_CPU_CHIP_TANGIER:
> > > > + id = x86_match_cpu(intel_mid_cpu_ids);
> > > > + if (id)
> > > > + model = id->model;
> > > > +
> > > > + switch (model) {
> > > > + case INTEL_FAM6_ATOM_SILVERMONT_MID:
> > >
> > > Is there a magic decoder ring somewhere that connects
> > > INTEL_MID_CPU_CHIP_TANGIER and INTEL_FAM6_ATOM_SILVERMONT_MID?
> >
> > Yes. And the idea is to get rid of it.
>
> OK. You don't want to even include a mention of it in the commit log
> to help people connect the dots and verify that this change is
> correct?
I think I missed it. I will update changelog for v2.
--
With Best Regards,
Andy Shevchenko
