"Derrick, Jonathan" <jonathan.derrick@xxxxxxxxx> writes: > On Tue, 2020-06-30 at 11:33 -0500, Bjorn Helgaas wrote: > I see that struct irqchip_fwid contains the actual fwnode structure and > when that is freed, it's causes the issue. > > I'm noticing in each caller of irq_domain_free_fwnode, we have the > domain itself available. It seems like it should be up to the caller to > deal with the fwnode pointer, but we could just do: Why? The fwnode pointer handling is inconsistent for the various fwnode types. We really don't want to go back to that state. Thanks, tglx