On Mon, Jul 13, 2020 at 04:02:40PM -0500, Bjorn Helgaas wrote: > On Mon, Jul 13, 2020 at 11:03:38PM +0300, Andy Shevchenko wrote: > > On Mon, Jul 13, 2020 at 02:59:07PM -0500, Bjorn Helgaas wrote: > > > On Mon, Jul 13, 2020 at 10:44:37PM +0300, Andy Shevchenko wrote: > > > > Describe missed parameter in documentation of type1_access_ok(). > > > > Otherwise we get the following warning: > > > > > > Would you mind including the "make" invocation that runs this > > > checking? I assume it's something like "make C=2 > > > arch/x86/pci/intel_mid_pci.o"? > > > > No, it is not sparse, it's a kernel doc validation. > > I guess `make W=1` does it, but I can repeat my command line publicly again :-) > > make W=1 C=1 CF=-D__CHECK_ENDIAN__ -j64 > > Thanks. "make W=1 arch/x86/pci/" is enough. I would just put this in > the commit log, e.g., > > Otherwise "make W=1 arch/x86/pci/" produces the following warning: > > CHECK arch/x86/pci/intel_mid_pci.c > CC arch/x86/pci/intel_mid_pci.o > arch/x86/pci/intel_mid_pci.c:152: warning: Function parameter or member 'reg' not described in 'type1_access_ok' Will do. -- With Best Regards, Andy Shevchenko
