On Mon, Jul 06, 2020 at 04:58:47PM +0100, Lorenzo Pieralisi wrote: > On Tue, Jun 02, 2020 at 09:01:13AM -0600, Rob Herring wrote: > > [...] > > > > The other 2 error cases as well don't print the resource name as far as > > > I recall (they will at least print the resource start/end). > > > > Start/end are what are important for why either of these functions > > failed. > > > > But sure, we could add 'name' here. That's a separate patch IMO. Hi Lorenzo, Bob and Jonathan: Thank you very much for helping me review this patch, I sent a new patch for print the resource name when the request memory region or remapping of configuration space fails. and it is here: https://patchwork.kernel.org/patch/11657801/ BR, Dejin > > I agree. In sum, I think it is OK to proceed with this patch, provided > we send follow-ups as discussed here, are we in agreement ? > > Lorenzo