On Mon, Jul 06, 2020 at 12:47:59PM +0200, Thomas Gleixner wrote:
> Bjorn Helgaas <helgaas@xxxxxxxxxx> writes:
> > On Tue, Jun 30, 2020 at 12:39:08PM +0300, Andy Shevchenko wrote:
> >> The problem here is in the original patch which relies on the
> >> knowledge that fwnode is (was) not used anyhow specifically for ACPI
> >> case. That said, it makes fwnode a dangling pointer which I
> >> personally consider as a mine left for others. That's why the Fixes
> >> refers to the initial commit. The latter just has been blasted on
> >> that mine.
>
> No. The original patch did not create a dangling pointer because fwnode
> was not stored for IRQCHIP_FWNODE_NAMED and IRQCHIP_FWNODE_NAMED_ID type
> nodes.
>
> The fail was introduced in:
>
> 711419e504eb ("irqdomain: Add the missing assignment of domain->fwnode for named fwnode")
Ah, sorry for missing that and thank you for pointing out.
--
With Best Regards,
Andy Shevchenko
