On Wed, 2020-06-24 at 10:22 -0700, Jakub Kicinski wrote: > On Wed, 24 Jun 2020 10:34:40 +0300 Aya Levin wrote: > > > > I think Michal will rightly complain that this does not belong > > > > in > > > > private flags any more. As (/if?) ARM deployments take a > > > > foothold > > > > in DC this will become a common setting for most NICs. > > > > > > Initially we used pcie_relaxed_ordering_enabled() to > > > programmatically enable this on/off on boot but this seems to > > > introduce some degradation on some Intel CPUs since the Intel > > > Faulty > > > CPUs list is not up to date. Aya is discussing this with Bjorn. > > Adding Bjorn Helgaas > > I see. Simply using pcie_relaxed_ordering_enabled() and blacklisting > bad CPUs seems far nicer from operational perspective. Perhaps Bjorn > will chime in. Pushing the validation out to the user is not a great > solution IMHO. > Can we move on with this patch for now ? since we are going to keep the user knob anyway, what is missing is setting the default value automatically but this can't be done until we fix pcie_relaxed_ordering_enabled()
