On Mon, Jun 22, 2020 at 04:03:30PM -0700, Sean V Kelley wrote:
> Root Complex Event Collectors provide support for terminating error
> and PME messages from RCiEPs. This patch provides basic decoding for
> lspci RCEC Endpoint Association Extended Capability. See PCie 5.0-1,
> sec 7.9.10 for further details.
s/lspci/the/
s/PCie/PCIe/
> Signed-off-by: Sean V Kelley <sean.v.kelley@xxxxxxxxxxxxxxx>
> ---
> lib/header.h | 8 +-
> ls-ecaps.c | 30 ++++-
> setpci.c | 2 +-
> tests/cap-rcec | 299 +++++++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 335 insertions(+), 4 deletions(-)
> create mode 100644 tests/cap-rcec
>
> diff --git a/lib/header.h b/lib/header.h
> index 472816e..deb5150 100644
> --- a/lib/header.h
> +++ b/lib/header.h
> @@ -219,7 +219,7 @@
> #define PCI_EXT_CAP_ID_PB 0x04 /* Power Budgeting */
> #define PCI_EXT_CAP_ID_RCLINK 0x05 /* Root Complex Link Declaration */
> #define PCI_EXT_CAP_ID_RCILINK 0x06 /* Root Complex Internal Link Declaration */
> -#define PCI_EXT_CAP_ID_RCECOLL 0x07 /* Root Complex Event Collector */
> +#define PCI_EXT_CAP_ID_RCEC 0x07 /* Root Complex Event Collector */
OK, not super descriptive, but it does match the kernel's definition
in pci_regs.h.
> #define PCI_EXT_CAP_ID_MFVC 0x08 /* Multi-Function Virtual Channel */
> #define PCI_EXT_CAP_ID_VC2 0x09 /* Virtual Channel (2nd ID) */
> #define PCI_EXT_CAP_ID_RCRB 0x0a /* Root Complex Register Block */
> @@ -1048,6 +1048,12 @@
> #define PCI_RCLINK_LINK_ADDR 8 /* Link Entry: Address (64-bit) */
> #define PCI_RCLINK_LINK_SIZE 16 /* Link Entry: sizeof */
>
> +/* Root Complex Event Collector */
This comment could mention "Endpoint Association", though.
> +#define PCI_RCEC_EP_CAP_VER(reg) (((reg) >> 16) & 0xf)
> +#define PCI_RCEC_BUSN_REG_VER 0x02 /* as per PCIe sec 7.9.10.1 */
> +#define PCI_RCEC_RCIEP_BMAP 0x0004 /* as per PCIe sec 7.9.10.2 */
> +#define PCI_RCEC_BUSN_REG 0x0008 /* as per PCIe sec 7.9.10.3 */
> +
> /* PCIe Vendor-Specific Capability */
> #define PCI_EVNDR_HEADER 4 /* Vendor-Specific Header */
> #define PCI_EVNDR_REGISTERS 8 /* Vendor-Specific Registers */
> diff --git a/ls-ecaps.c b/ls-ecaps.c
> index e71209e..589332d 100644
> --- a/ls-ecaps.c
> +++ b/ls-ecaps.c
> @@ -634,6 +634,32 @@ cap_rclink(struct device *d, int where)
> }
> }
>
> +static void
> +cap_rcec(struct device *d, int where)
> +{
> + printf("Root Complex Event Collector\n");
This could mention "Endpoint Association", too.
> + if (verbose < 2)
> + return;
> +
> + if (!config_fetch(d, where, 12))
> + return;
> +
> + u32 hdr = get_conf_long(d, where);
> + byte cap_ver = PCI_RCEC_EP_CAP_VER(hdr);
> + u32 bmap = get_conf_long(d, where + PCI_RCEC_RCIEP_BMAP);
> + printf("\t\tDesc:\tCapabilityVersion=%02x RCiEPBitmap=%08x\n",
> + cap_ver,
> + bmap);
I don't think "Desc:" is necessary.
Isn't "cap_ver" already printed as part of the header?
Capabilities: [160 v2] Root Complex Event Collector
^^
The "bmap" is a bitmap of device numbers of RCiEPs on the same bus as
the RCEC that are associated with this RCEC. Could be decoded as a
list, e.g., "0, 1, 2, 8" or "0-3, 8". Or maybe the hex bitmap is
enough. Not sure how much trouble this would be worth or if there are
other examples in lspci to copy.
> + if (cap_ver < PCI_RCEC_BUSN_REG_VER)
> + return;
> +
> + u32 busn = get_conf_long(d, where + PCI_RCEC_BUSN_REG);
> + printf("\t\t\tRCECLastBus=%02x RCECFirstBus=%02x\n",
> + BITS(busn, 16, 8),
> + BITS(busn, 8, 8));
> +}
