On Mon, Jun 22, 2020 at 6:08 PM Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx> wrote: > On Mon, 2020-06-22 at 17:42 +0300, Andy Shevchenko wrote: > > On Mon, Jun 22, 2020 at 5:26 PM Nicolas Saenz Julienne > > <nsaenzjulienne@xxxxxxx> wrote: ... > > > + struct device_node *fw_node; > > > > If you are going to use fwnode (as it should be), make sure the proper > > data type is in use, i.e. struct fwnode_handle. > > > > Otherwise, if you want to be OF centric (I discourage this, don't know > > if RPi4 is ever going to run RHEL or other distros that require non-DT > > firmwares), don't name fw_node. It's confusing. > > I agree it is confusing. I'll rename it. On the other hand, this is strictly DT > centric. AFAIU struct device_node *np is a usual pattern in OF-only world. -- With Best Regards, Andy Shevchenko
