Hi Nicolas, On Tue, 2020-06-09 at 13:18 +0200, Nicolas Saenz Julienne wrote: > Hi Florian, thanks for the reviews! > > On Mon, 2020-06-08 at 12:43 -0700, Florian Fainelli wrote: > > On 6/8/2020 12:26 PM, Nicolas Saenz Julienne wrote: > > > Some atypical users of xhci-pci might need to manually reset their xHCI > > > controller before starting the HCD setup. Check if a reset controller > > > device is available to the PCI bus and trigger a reset. > > > > > > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx> > > > --- > > > drivers/usb/host/xhci-pci.c | 9 +++++++++ > > > 1 file changed, 9 insertions(+) > > > > > > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c > > > index ef513c2fb843..45f70facdfcd 100644 > > > --- a/drivers/usb/host/xhci-pci.c > > > +++ b/drivers/usb/host/xhci-pci.c [...] > > > @@ -347,6 +349,13 @@ static int xhci_pci_probe(struct pci_dev *dev, const > > > struct pci_device_id *id) > > > return retval; > > > } > > > > > > + reset = devm_reset_control_get(&dev->bus->dev, NULL); > > > > Should not this be devm_reset_control_get_optional()? > > Yes, you're right. Please use devm_reset_control_get_optional_exclusive() while you're at it. regards Philipp
