Thank you for your advice. I will fix these problems in the next edition of patch. "Thierry Reding" <thierry.reding@xxxxxxxxx>写道： > On Wed, May 20, 2020 at 04:52:23PM +0800, Dinghao Liu wrote: > > pm_runtime_get_sync() increments the runtime PM usage counter even > > it returns an error code. Thus a pairing decrement is needed on > > s/even it/even when it/ > > Might also be a good idea to use a different subject prefix because I > was almost not going to look at the other patch, taking this to be a > replacement for it. > > Although, looking at the log we have used this same prefix for both > drivers in the past... > > > the error handling path to keep the counter balanced. > > > > Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx> > > --- > > drivers/pci/controller/dwc/pcie-tegra194.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c > > index ae30a2fd3716..a69f9e49dcb5 100644 > > --- a/drivers/pci/controller/dwc/pcie-tegra194.c > > +++ b/drivers/pci/controller/dwc/pcie-tegra194.c > > @@ -1651,8 +1651,8 @@ static int tegra_pcie_config_rp(struct tegra_pcie_dw *pcie) > > fail_host_init: > > tegra_pcie_deinit_controller(pcie); > > fail_pinctrl: > > - pm_runtime_put_sync(dev); > > fail_pm_get_sync: > > Either of those two labels is now no longer needed. Of course it'll now > be odd to jump to fail_pm_get_sync on pinctrl_pm_select_default_state() > failure, but that's one of the reasons why label should have names > describing what they do rather than describe the failure location. I > guess we can live with that for now. I'll make a note to send a cleanup > patch for that later on. > > With the fixup in the commit message and either of the labels removed: > > Acked-by: Thierry Reding <treding@xxxxxxxxxx>
