On Tue, Apr 28, 2020 at 09:32:31AM +0100, Lorenzo Pieralisi wrote: > On Sun, Apr 26, 2020 at 02:31:47PM +0200, marek.vasut@xxxxxxxxx wrote: > > From: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> > > > > The PHY initialization function pointer does not change during the > > lifetime of the driver instance, it is therefore sufficient to get > > the pointer in .probe(), cache it in driver private data, and just > > call the function through the cached pointer in .resume(). > > > > Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> > > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx> > > Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx> > > Cc: linux-renesas-soc@xxxxxxxxxxxxxxx > > --- > > NOTE: Based on git://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git > > branch pci/rcar > > NOTE: The driver tag is now 'pcie-rcar' to distinguish it from pci-rcar-gen2.c > > --- > > drivers/pci/controller/pcie-rcar.c | 10 ++++------ > > 1 file changed, 4 insertions(+), 6 deletions(-) > > Squashed in https://patchwork.kernel.org/patch/11438665 > > Do you want me to rename the $SUBJECT (and the branch name while at it) > in the patches in my pci/rcar branch ("PCI: pcie-rcar: ...") to start > the commit subject tag renaming from this cycle (and in the interim you > send a rename for the drivers files ?) My vote is a tag of "rcar" for the pcie-rcar driver because almost all new drivers are PCIe, and none of the others use "pcie-" in the tag. For pci-rcar-gen2.c, we could use "rcar-gen2" (already used by the last 5 commits, last touched over two years ago). It's slightly confusing to use "gen2" to refer to some internal R-Car thing instead of PCIe Gen 2, so we could use something like "rcar-pci", but I'm not sure it's worth it. Bjorn