> > > > Uncapitalize "legacy power management" in subject. I'd say "convert", > > not "remove", to make it clear that the driver will still do power > > management afterwards. Sure! > > > > I think your to: and cc: list came from the get_maintainer.pl script, yeah. > > but you can trim it a bit by omitting people who have just made > > occasional random fixups. These drivers are really unmaintained, so > > Dave M, netdev, Rafael, linux-pm, linux-pci, and maybe LKML are > > probably enough. I will keep this in mind next time. > > > > On Tue, Apr 28, 2020 at 08:13:13PM +0530, Vaibhav Gupta wrote: > > > Upgrade power management from legacy to generic using dev_pm_ops. > > > > Instead of the paragraphs below, which cover the stuff that's fairly > > obvious, I think it would be more useful to include hints about where > > the things you removed will be done now. That helps reviewers verify > > that this doesn't break anything. E.g., > > > > In the legacy PM model, drivers save and restore PCI state and set > > the device power state directly. In the generic model, this is all > > done by the PCI core in .suspend_noirq() (pci_pm_suspend_noirq()) > > and .resume_noirq() (pci_pm_resume_noirq()). > > > > This sort of thing could go in each commit log. The cover letter > > doesn't normally go in the commit log, so you have to assume it will > > be lost. Okay. I will send v3 patch-series with changes. Thanks for acknowledging :) --Vaibhav Gupta > > > > > Remove "struct pci_driver.suspend" and "struct pci_driver.resume" > > > bindings, and add "struct pci_driver.driver.pm" . > > >
