On Wed, Apr 15, 2020 at 05:38:32PM -0700, sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx wrote:
> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
>
> Currently we have pci_info() message in the beginning of
> edr_handle_event() function, which will be printing
> notification details every-time firmware sends ACPI SYSTEM
> level events. This will pollute the dmesg logs for systems
> that has lot for ACPI system level notifications. So change
> the log-level to pci_dbg, and add a new info log for EDR
> events.
>
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
> ---
> drivers/pci/pcie/edr.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pcie/edr.c b/drivers/pci/pcie/edr.c
> index 594622a6cb16..e346c82559fa 100644
> --- a/drivers/pci/pcie/edr.c
> +++ b/drivers/pci/pcie/edr.c
> @@ -148,11 +148,13 @@ static void edr_handle_event(acpi_handle handle, u32 event, void *data)
> pci_ers_result_t estate = PCI_ERS_RESULT_DISCONNECT;
> u16 status;
>
> - pci_info(pdev, "ACPI event %#x received\n", event);
> + pci_dbg(pdev, "ACPI event %#x received\n", event);
I agree this looks excessively verbose. Do we even need a pci_dbg()
message here? Maybe a message like that would belong in ACPI?
There is already an ACPI_DEBUG_PRINT() in
acpi_ev_queue_notify_request() that would serve a similar purpose.
> if (event != ACPI_NOTIFY_DISCONNECT_RECOVER)
> return;
>
> + pci_info(pdev, "EDR event received\n");
> +
> /* Locate the port which issued EDR event */
> edev = acpi_dpc_port_get(pdev);
> if (!edev) {
> --
> 2.17.1
>
