On Thursday 23 April 2020 20:56:27 Pali Rohár wrote: > On Thursday 23 April 2020 13:39:14 Bjorn Helgaas wrote: > > [+cc Rob] > > > > On Tue, Apr 21, 2020 at 01:16:55PM +0200, Marek Behún wrote: > > > Currently the aardvark driver trains link in PCIe gen2 mode. This may > > > cause some buggy gen 1 cards (such as Compex WLE900VX) to be unstable or > > > even not detected. Moreover when ASPM code tries to retrain link second > > > time, these cards may stop responding and link goes down. If gen1 is > > > used this does not happen. > > > > Does this patch make the retrain done by ASPM reliable? > > Yes, after this patch all my tested cards work fine. I tried to enable > ASPM for tested cards and there were no problem with link training > issued by ASPM kernel code. > > So this patch makes link retrain done by ASPM kernel code reliable. It works fine also for WLE200NX card. ASPM kernel code decides that for this card ASPM needs to be disabled. In dmesg output I see: [ 3.229229] pci 0000:01:00.0: disabling ASPM on pre-1.1 PCIe device. You can enable it with 'pcie_aspm=force' Kernel disables ASPM, retrains link and card is working fine.
