On Tue, Apr 21, 2020 at 02:21:34PM +0100, Shiju Jose wrote: > static BLOCKING_NOTIFIER_HEAD(ghes_event_notify_list); > @@ -670,12 +692,7 @@ static void ghes_do_proc(struct ghes *ghes, > pr_warn(GHES_PFX "ghes event queue full\n"); > break; > } > - > - if (guid_equal(sec_type, &CPER_SEC_PROC_ARM)) { > - struct cper_sec_proc_arm *err = acpi_hest_get_payload(gdata); > - > - log_arm_hw_error(err); > - } else { > + { > void *err = acpi_hest_get_payload(gdata); This is ugly. Just move the "void *err;" declaration to the top of the function so we can delete this block. > > log_non_standard_event(sec_type, fru_id, fru_text, > -- regards, dan carpenter