On Fri, Apr 17, 2020 at 9:17 PM Max Gurtovoy <maxg@xxxxxxxxxxxx> wrote:
>
> > The enable and disable path shares almost no code, why not split it into
> > two functions?
>
> how about also changing the defines OPAL_PCI_P2P_* to an enum ?
>
> /* PCI p2p operation descriptors */
> enum opal_pci_p2p {
>
> OPAL_PCI_P2P_DISABLE = 0,
>
> OPAL_PCI_P2P_ENABLE = (1 << 0),
> OPAL_PCI_P2P_LOAD = (1 << 1),
> OPAL_PCI_P2P_STORE = (1 << 2),
> };
>
> Fred ?
I'd rather you didn't. We try to keep the definitions in opal-api.h
the same as the skiboot's opal-api.h since the skiboot version is
canonical.
Also, generally patches to anything PowerNV related go through the
powerpc tree rather than the pci tree even if they're PCI related. Can
you make sure you have linuxppc-dev CCed when you post v2.
Oliver
