On Tue, Apr 14, 2020 at 12:25:12PM +0200, Pali Rohár wrote:
> Error code is stored in rp->reset_gpio and not in err variable.
>
> Signed-off-by: Pali Rohár <pali@xxxxxxxxxx>
> ---
> drivers/pci/controller/pci-tegra.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
> index 0e03cef72840..378d5a8773c7 100644
> --- a/drivers/pci/controller/pci-tegra.c
> +++ b/drivers/pci/controller/pci-tegra.c
> @@ -2314,8 +2314,8 @@ static int tegra_pcie_parse_dt(struct tegra_pcie *pcie)
> if (PTR_ERR(rp->reset_gpio) == -ENOENT) {
> rp->reset_gpio = NULL;
> } else {
> - dev_err(dev, "failed to get reset GPIO: %d\n",
> - err);
> + dev_err(dev, "failed to get reset GPIO: %ld\n",
> + PTR_ERR(rp->reset_gpio));
> return PTR_ERR(rp->reset_gpio);
> }
> }
You can use %pe directly on the pointer for added benefit of translation
of the error to a name.
Best Regards,
Michał Mirosław
