On Mon, Mar 16, 2020 at 08:46:59AM -0700, Christoph Hellwig wrote: > On Fri, Mar 06, 2020 at 09:09:19AM -0400, Jason Gunthorpe wrote: > > This is why release must do invalidate all - but it doesn't need to do > > any more - as no SPTE can be established without a mmget() - and > > mmget() is no longer possible past release. > > Maybe we should rename the release method to invalidate_all? It is a better name. The function it must also fence future access if the mirror is not using mmget(), and stop using the pgd/etc pointer if the page tables are accessed directly. Jason