Bjorn Helgaas <helgaas@xxxxxxxxxx> writes: > On Thu, Mar 12, 2020 at 09:38:02AM -0500, Bjorn Helgaas wrote: >> On Thu, Mar 12, 2020 at 10:04:12PM +0800, Chen Zhou wrote: >> > Fixes gcc '-Wunused-but-set-variable' warning: >> > >> > drivers/pci/hotplug/rpaphp_core.c: In function is_php_type: >> > drivers/pci/hotplug/rpaphp_core.c:291:16: warning: >> > variable value set but not used [-Wunused-but-set-variable] >> > >> > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> >> > Signed-off-by: Chen Zhou <chenzhou10@xxxxxxxxxx> >> >> Michael, if you want this: >> >> Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> >> >> If you don't mind, edit the subject to follow the convention, e.g., >> >> PCI: rpaphp: Remove unused variable 'value' >> >> Apparently simple_strtoul() is deprecated and we're supposed to use >> kstrtoul() instead. Looks like kstrtoul() might simplify the code a >> little, too, e.g., >> >> if (kstrtoul(drc_type, 0, &value) == 0) >> return 1; >> >> return 0; > > I guess there are several other uses of simple_strtoul() in this file. > Not sure if it's worth changing them all, just this one, or just the > patch below as-is. I'll take this patch as-is, and someone can send a follow-up to convert the whole file to kstrtoul(). cheers
