Hi Aman,
1) Check your mailer config. These messages had no "To:" header, so
replying didn't work correctly. I added "Cc: linux-pci" manually, but
on the mailing lists, the convention is to "reply-all" so everybody
can participate.
2) The cc list is a little bit overboard.
"$ ./scripts/get_maintainer.pl -f drivers/pci/controller/pci-v3-semi.c"
shows Linus W, Lorenzo, Andrew, myself, linux-pci, linux-kernel.
That's plenty.
3) Study "git log drivers/pci" and make your commit subjects and
logs match the convention in capitalization, sentence structure, verb
tense, etc.
4) Every commit must have non-empty log, even if the commit seems
trivial. The log message should be independent of the subject. The
subject is like an essay title; the log message is like the essay
body. The body is separate from the title, not a continuation of it.
5) Function names in subjects and logs have "()" after them.
6) Cite previous similar work, e.g., mention ef75369a5b9a ("PCI:
altera: Fix platform_get_irq() error handling"), which is one of many
similar patches.
7) You mentioned similar issues with platform_get_irq_byname().
Please add patches in this series to fix them as well.
8) You asked about dev_err() usage. See 6c9050a73469 ("irqchip:
Remove dev_err() usage after platform_get_irq()") and feel free to do
the same here. If you do, cite that commit in your commit log.
I think the patches themselves look OK, and the series is correctly
structured with a cover letter and patches as responses to the cover.
When you post a revised series, make sure it's labeled "PATCH v2 0/5".
Thanks,
Bjorn
On Thu, Mar 12, 2020 at 12:49:02AM +0530, Aman Sharma wrote:
> Signed-off-by: Aman Sharma <amanharitsh123@xxxxxxxxx>
> ---
> drivers/pci/controller/pci-v3-semi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/pci-v3-semi.c b/drivers/pci/controller/pci-v3-semi.c
> index bd05221f5a22..a5bf945d2eda 100644
> --- a/drivers/pci/controller/pci-v3-semi.c
> +++ b/drivers/pci/controller/pci-v3-semi.c
> @@ -777,9 +777,9 @@ static int v3_pci_probe(struct platform_device *pdev)
>
> /* Get and request error IRQ resource */
> irq = platform_get_irq(pdev, 0);
> - if (irq <= 0) {
> + if (irq < 0) {
> dev_err(dev, "unable to obtain PCIv3 error IRQ\n");
> - return -ENODEV;
> + return irq;
> }
> ret = devm_request_irq(dev, irq, v3_irq, 0,
> "PCIv3 error", v3);
> --
> 2.20.1
>
