On Wed, 2020-03-04 at 10:05 +0100, Greg KH wrote:
> On Mon, Mar 02, 2020 at 04:55:28PM +0100, Nicolas Saenz Julienne wrote:
> > @@ -1243,11 +1246,26 @@ static void quirk_usb_handoff_xhci(struct pci_dev
> > *pdev)
> >
> > static void quirk_usb_early_handoff(struct pci_dev *pdev)
> > {
> > + int ret;
> > +
> > /* Skip Netlogic mips SoC's internal PCI USB controller.
> > * This device does not need/support EHCI/OHCI handoff
> > */
> > if (pdev->vendor == 0x184e) /* vendor Netlogic */
> > return;
> > +
> > + if (pdev->vendor == PCI_VENDOR_ID_VIA && pdev->device == 0x3483) {
> > + ret = rpi_firmware_init_vl805(pdev);
> > + if (ret)
> > + /*
> > + * Firmware might be outdated, or else, something
> > + * failed, keep going and hope for the best.
> > + */
> > + dev_warn(&pdev->dev,
> > + "Failed to load VL805's firmware: %d\n",
> > + ret);
>
> {} please.
>
> Also, you might want to provide a better warning, something like:
> "Failed to load VL805's firmware, will continue to attempt to
> work, but bad things might happen, you should fix this..."
>
> or something to give people a chance to know what to do here.
Noted
Thanks,
Nicolas
Attachment:
signature.asc
Description: This is a digitally signed message part
