Hi Bjorn,
On 3/3/2020 9:04 AM, Bjorn Helgaas wrote:
On Thu, Feb 27, 2020 at 04:59:45PM -0800, sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx wrote:
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
Currently we pass PCIe service type parameter to pcie_do_recovery()
function which was in-turn used by reset_link() function to identify
the underlying pci_port_service_driver and then initiate the driver
specific reset_link call. Instead of using this roundabout way, we
can just pass the driver specific reset_link callback function when
calling pcie_do_recovery() function.
I love this! And I think pcie_port_find_service() is now unused. I
can add a patch to remove it.
I can submit a patch to remove it in next version.
Along with this, I think we also need to remove reset_link pointer from
pcie_port_service_driver. Also we need to make relevant changes in
Documentation/PCI/pcieaer-howto.rst as well.
I will wait for you to review rest of the patches before sending the
next version. Please let me know if you want me to just fix this and
send it.
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
