On Wed, 2020-02-19 at 11:21 -0800, Florian Fainelli wrote: > On 2/19/20 4:39 AM, Nicolas Saenz Julienne wrote: > > xHCI's PCI fixup, run at the end of pcie-brcmstb's probe, depends on > > RPi4's VideoCore firmware interface to be up and running. It's possible > > for both initializations to race, so make sure it's available prior > > starting. > > > > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx> > > Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx> > > It does not look like there is something making sure that > CONFIG_RASPBERRYPI_FIRMWARE is being selected or depended on, should we > have a "default XHCI_PCI" added to drivers/firmware/Kconfig? I think having that would enable the firmware interface for all XHCI_PCI users, which isn't ideal. The firmware call has stubs for the case the firmware interace isn't compiled, so no problem there. Ultimately we want to enable CONFIG_RASPBERRYPI_FIRMWARE only when the built image targets the RPi4 (reglardless of being arm64/arm32). But I don't think that's feasible. Regards, Nicolas
Attachment:
signature.asc
Description: This is a digitally signed message part
