On 2/12/2020 6:59 PM, Jaedon Shin wrote: > Add PCIe support for ARM-based Broadcom STB SoCs. > > Signed-off-by: Jaedon Shin <jaedon.shin@xxxxxxxxx> > --- > Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 8 +++++++- > drivers/pci/controller/Kconfig | 2 +- > drivers/pci/controller/pcie-brcmstb.c | 1 + > 3 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > index 77d3e81a437b..fb1a78606f78 100644 > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > @@ -14,7 +14,13 @@ allOf: > > properties: > compatible: > - const: brcm,bcm2711-pcie # The Raspberry Pi 4 > + oneOf: > + - description: > + BCM2711 based Boards > + const: brcm,bcm2711-pcie > + - description: > + ARM-based BCM7XXX Broadcom STB Boards > + const: brcm,bcm7445-pcie You would also need to document the regulator properties as optional here. > > reg: > maxItems: 1 > diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig > index 20bf00f587bd..c60a27cff81a 100644 > --- a/drivers/pci/controller/Kconfig > +++ b/drivers/pci/controller/Kconfig > @@ -254,7 +254,7 @@ config VMD > > config PCIE_BRCMSTB > tristate "Broadcom Brcmstb PCIe host controller" > - depends on ARCH_BCM2835 || COMPILE_TEST > + depends on ARCH_BCM2835 || ARCH_BRCMSTB || COMPILE_TEST This part looks entirely reasonable. -- Florian
