Add pcie_port_slot_emulated hook and wire it up to pciehp_emul. Add pciehp_emul_{attach,detach} calls in pciehp and move the management check into the attach caller. Signed-off-by: Jon Derrick <jonathan.derrick@xxxxxxxxx> --- drivers/pci/hotplug/pciehp.h | 18 ++++++++++++++++++ drivers/pci/hotplug/pciehp_emul.c | 11 ++++++++--- drivers/pci/hotplug/pciehp_hpc.c | 4 ++++ drivers/pci/pcie/portdrv_core.c | 3 +++ include/linux/pci.h | 4 ++++ 5 files changed, 37 insertions(+), 3 deletions(-) diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h index 48fdd62..035d44d 100644 --- a/drivers/pci/hotplug/pciehp.h +++ b/drivers/pci/hotplug/pciehp.h @@ -197,6 +197,24 @@ struct controller { int pciehp_set_raw_indicator_status(struct hotplug_slot *h_slot, u8 status); int pciehp_get_raw_indicator_status(struct hotplug_slot *h_slot, u8 *status); +#ifdef CONFIG_HOTPLUG_PCI_PCIE_EMUL +bool pciehp_emul_will_manage(struct pci_dev *dev); +int pciehp_emul_attach(struct controller *ctrl); +void pciehp_emul_detach(struct controller *ctrl); +#else +static inline bool pciehp_emul_will_manage(struct pci_dev *dev) +{ + return false; +}; + +static inline int pciehp_emul_attach(struct controller *ctrl) +{ + return 0; +}; + +static inline void pciehp_emul_detach(struct controller *ctrl) {}; +#endif + static inline const char *slot_name(struct controller *ctrl) { return hotplug_slot_name(&ctrl->hotplug_slot); diff --git a/drivers/pci/hotplug/pciehp_emul.c b/drivers/pci/hotplug/pciehp_emul.c index 1a1fb51..b41bbae 100644 --- a/drivers/pci/hotplug/pciehp_emul.c +++ b/drivers/pci/hotplug/pciehp_emul.c @@ -281,9 +281,6 @@ int pciehp_emul_attach(struct controller *ctrl) u32 slotcap = 0; int ret; - if (!pciehp_emul_will_manage(dev)) - return 0; - emul = kzalloc(sizeof(*emul), GFP_KERNEL); if (!emul) return -ENOMEM; @@ -371,3 +368,11 @@ void pciehp_emul_detach(struct controller *ctrl) kfree(emul); } + +static int __init pciehp_emul_init(void) +{ + pcie_port_slot_emulated = &pciehp_emul_will_manage; + + return 0; +} +postcore_initcall(pciehp_emul_init); diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c index e46f177..e034ab0 100644 --- a/drivers/pci/hotplug/pciehp_hpc.c +++ b/drivers/pci/hotplug/pciehp_hpc.c @@ -922,6 +922,10 @@ struct controller *pcie_init(struct pcie_device *dev) ctrl->pcie = dev; ctrl->slot_ops = &pciehp_default_slot_ops; + + if (pciehp_emul_will_manage(pdev) && pciehp_emul_attach(ctrl)) + return NULL; + pcie_read_slot_capabilities(ctrl, &slot_cap); if (pdev->hotplug_user_indicators) diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c index 5979bb7..a1efaf7 100644 --- a/drivers/pci/pcie/portdrv_core.c +++ b/drivers/pci/pcie/portdrv_core.c @@ -19,6 +19,9 @@ #include "../pci.h" #include "portdrv.h" +/* Hook for hotplug emulation driver */ +bool (*pcie_port_slot_emulated)(struct pci_dev *dev); + struct portdrv_service_data { struct pcie_port_service_driver *drv; struct device *dev; diff --git a/include/linux/pci.h b/include/linux/pci.h index c5c9bb5..3b48968 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -1538,7 +1538,11 @@ static inline int pci_irqd_intx_xlate(struct irq_domain *d, #define pcie_ports_native false #endif +#ifdef CONFIG_HOTPLUG_PCI_PCIE_EMUL +extern bool (*pcie_port_slot_emulated)(struct pci_dev *dev); +#else #define pcie_port_slot_emulated(dev) false +#endif #define PCIE_LINK_STATE_L0S BIT(0) #define PCIE_LINK_STATE_L1 BIT(1) -- 1.8.3.1