Re: [PATCH] PCI: Improve link speed presentation process

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bjorn, 
It seems like we have met the problem you indicated, that using pci_bus_speed_strings[] in
PCIE_BUS_SPEED2STR macro is only available when CONFIG_SYSFS=y.

I have moved the string array to probe.c in the new patch set according to the suggestions.
I hope it has not been buried in the mail list.
https://lore.kernel.org/linux-pci/1579079063-5668-1-git-send-email-yangyicong@xxxxxxxxxxxxx/

On 2020/1/16 15:45, kbuild test robot wrote:
> Hi Yicong,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on pci/next]
> [also build test ERROR on v5.5-rc6 next-20200110]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
>
> url:    https://github.com/0day-ci/linux/commits/Yicong-Yang/PCI-Improve-link-speed-presentation-process/20200114-163536
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
> config: ia64-allnoconfig (attached as .config)
> compiler: ia64-linux-gcc (GCC) 7.5.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.5.0 make.cross ARCH=ia64 
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
>
> All errors (new ones prefixed by >>):
>
>    drivers/pci/pci-sysfs.o: In function `max_link_speed_show':
>>> pci-sysfs.c:(.text+0x1e01): undefined reference to `pci_bus_speed_strings'
>    pci-sysfs.c:(.text+0x1e10): undefined reference to `pci_bus_speed_strings'
>    drivers/pci/pci-sysfs.o: In function `current_link_speed_show':
>    pci-sysfs.c:(.text+0x2070): undefined reference to `pci_bus_speed_strings'
>    pci-sysfs.c:(.text+0x2080): undefined reference to `pci_bus_speed_strings'
>
> ---
> 0-DAY kernel test infrastructure                 Open Source Technology Center
> https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx Intel Corporation





[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux