'InterComm' is the spelling in the latest datasheet, it's short for "Inter Fabric Manager Communication". Thanks. Kelvin -----Original Message----- From: Logan Gunthorpe [mailto:logang@xxxxxxxxxxxx] Sent: Thursday, January 9, 2020 5:48 AM To: Bjorn Helgaas <helgaas@xxxxxxxxxx> Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; Kelvin Cao - A31060 <Kelvin.Cao@xxxxxxxxxxxxx>; Eric Pilmore <epilmore@xxxxxxxxxx>; Doug Meyer <dmeyer@xxxxxxxxxx> Subject: Re: [PATCH 03/12] PCI/switchtec: Add support for new events EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe On 2020-01-08 2:33 p.m., Bjorn Helgaas wrote: > On Mon, Jan 06, 2020 at 12:03:28PM -0700, Logan Gunthorpe wrote: >> The intercomm notify event was added for PAX variants of switchtec >> hardware and the UEC Port was added for the MR1 release of GEN3 firmware. > > Do they actually spell it "intercomm" in the datasheet? Seems like > the most common English spelling is "intercom". Hmm, not sure I don't have this event in my datasheet which is a little out of date. Kelvin, whose CC'd, would know if we can change the spelling hopefully he can weigh in on this. As far as I know the define isn't used anywhere yet. > Is there some meaningful expansion of "UEC"? Upstream Error Containment -- I'll mention that in the commit message. Logan >> Signed-off-by: Logan Gunthorpe <logang@xxxxxxxxxxxx> >> --- >> drivers/pci/switch/switchtec.c | 3 +++ >> include/linux/switchtec.h | 7 +++++-- >> include/uapi/linux/switchtec_ioctl.h | 4 +++- >> 3 files changed, 11 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/pci/switch/switchtec.c >> b/drivers/pci/switch/switchtec.c index 9c3ad09d3022..218e67428cf9 >> 100644 >> --- a/drivers/pci/switch/switchtec.c >> +++ b/drivers/pci/switch/switchtec.c >> @@ -751,10 +751,13 @@ static const struct event_reg { >> EV_PAR(SWITCHTEC_IOCTL_EVENT_MRPC_COMP, mrpc_comp_hdr), >> EV_PAR(SWITCHTEC_IOCTL_EVENT_MRPC_COMP_ASYNC, mrpc_comp_async_hdr), >> EV_PAR(SWITCHTEC_IOCTL_EVENT_DYN_PART_BIND_COMP, >> dyn_binding_hdr), >> + EV_PAR(SWITCHTEC_IOCTL_EVENT_INTERCOMM_REQ_NOTIFY, >> + intercomm_notify_hdr),
