On Tue, Jan 07, 2020 at 03:08:06PM -0700, Sushma Kalakota wrote:
> Add new VMD device IDs that require the bus restriction mode.
>
> Signed-off-by: Sushma Kalakota <sushmax.kalakota@xxxxxxxxx>
> Signed-off-by: Jon Derrick <jonathan.derrick@xxxxxxxxx>
> ---
> drivers/pci/controller/vmd.c | 4 ++++
> include/linux/pci_ids.h | 2 ++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
> index 212842263f55..9433bd387fdd 100644
> --- a/drivers/pci/controller/vmd.c
> +++ b/drivers/pci/controller/vmd.c
> @@ -868,6 +868,10 @@ static const struct pci_device_id vmd_ids[] = {
> {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_28C0),
> .driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW |
> VMD_FEAT_HAS_BUS_RESTRICTIONS,},
> + {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_467F),
> + .driver_data = VMD_FEAT_HAS_BUS_RESTRICTIONS,},
> + {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_4C3D),
> + .driver_data = VMD_FEAT_HAS_BUS_RESTRICTIONS,},
> {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_9A0B),
> .driver_data = VMD_FEAT_HAS_BUS_RESTRICTIONS,},
> {0,}
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 2302d133af6f..aac007c60f87 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2957,6 +2957,8 @@
> #define PCI_DEVICE_ID_INTEL_SBRIDGE_BR 0x3cf5 /* 13.6 */
> #define PCI_DEVICE_ID_INTEL_SBRIDGE_SAD1 0x3cf6 /* 12.7 */
> #define PCI_DEVICE_ID_INTEL_IOAT_SNB 0x402f
> +#define PCI_DEVICE_ID_INTEL_VMD_467F 0x467f
> +#define PCI_DEVICE_ID_INTEL_VMD_4C3D 0x4c3d
Please don't add pci_ids.h constants there are only used in a single
driver. Especially so if they are totally non-descriptive.
