> On Dec 18, 2019, at 1:24 PM, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > > Ugh, that is pretty subtle! Would you mind if we used "unsigned int" > instead of "u16"? "u16" makes it look like just a mistake -- somebody > is likely to come along and say devfn only needs "u8" and try to > change it back. The same might happen with "unsigned int", but at > least it doesn't look like it was chosen specifically to fit a devfn. > > Provisional patch below. Looks good to me.