On 12/11/19 4:02 PM, Bjorn Helgaas wrote:
On Wed, Dec 11, 2019 at 5:40 PM Ray Jui <ray.jui@xxxxxxxxxxxx> wrote:
On 12/11/19 2:34 PM, Bjorn Helgaas wrote:
On Wed, Dec 11, 2019 at 05:45:11PM +0000, Wei Liu wrote:
The quirks were originally enclosed by ifdef. That made the quirks not
to be applied when respective drivers were compiled as modules.
Move the quirks to driver code to fix the issue.
Signed-off-by: Wei Liu <wei.liu@xxxxxxxxxx>
This straddles the core and native driver boundary, so I applied it to
pci/misc for v5.6. Thanks, I think this is a great solution! It's
always nice when we can encapsulate device-specific things in a
driver.
Opps! I was going to review and comment and you are quick, :)
I was going to say, I think it's better to keep this quirk in
"pcie-iproc.c" instead of "pcie-iproc-platform.c".
The quirk is specific to certain PCIe devices under iProc (activated
based on device ID), but should not be tied to a specific bus
architecture (i.e., platform vs BCMA).
I'm happy to move it; that's no problem.
Thanks, Bjorn!
