On Tue, 3 Dec 2019 at 14:42, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > > On Tue, Dec 03, 2019 at 02:06:57PM +0000, Wei Liu wrote: > > On Wed, 27 Nov 2019 at 10:59, Wei Liu <wei.liu@xxxxxxxxxx> wrote: > > > > > > On Tue, 26 Nov 2019 at 23:05, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > > > > > > > > On Fri, Nov 15, 2019 at 01:58:42PM +0000, Wei Liu wrote: > > > > > CONFIG_PCIE_IPROC_PLATFORM only gets defined when the driver is built > > > > > in. Removing the ifdef will allow us to build the driver as a module. > > > > > > > > > > Signed-off-by: Wei Liu <wei.liu@xxxxxxxxxx> > > > > > > > > Sorry, I missed this thinking it would be under drivers/pci/controller > > > > and hence handled by Lorenzo. > > > > > > > > So I guess this doesn't fix a build problem, but without this patch, > > > > we just don't run the quirk if the driver is a module, right? > > > > > > Yes, this is correct. > > > > > > Without this patch, the quirk doesn't get to run if the driver is a module. > > > > Are you satisfied with the patch? What do I need to do to get it merged? > > You needn't do anything. I'll clarify the changelog (the patch > doesn't actually *enable* building the driver as a module; it merely > ensures that we include the quirk in that case). > > This is too late for v5.5, so it will get merged for v5.6 unless the > modular driver itself was enabled for v5.5. > OK. Thanks for the clarification. Wei. > Bjorn
