On Fri, Nov 15, 2019 at 01:58:42PM +0000, Wei Liu wrote:
> CONFIG_PCIE_IPROC_PLATFORM only gets defined when the driver is built
> in. Removing the ifdef will allow us to build the driver as a module.
>
> Signed-off-by: Wei Liu <wei.liu@xxxxxxxxxx>
Sorry, I missed this thinking it would be under drivers/pci/controller
and hence handled by Lorenzo.
So I guess this doesn't fix a build problem, but without this patch,
we just don't run the quirk if the driver is a module, right?
> ---
> Alternatively, we can change the condition to:
>
> #ifdef CONFIG_PCIE_IPROC_PLATFORM || CONFIG_PCIE_IPROC_PLATFORM_MODULE
>
> I chose to remove the ifdef because that's what other quirks looked like
> in this file.
> ---
> drivers/pci/quirks.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 320255e5e8f8..cd0e7c18e717 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -2381,7 +2381,6 @@ DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_BROADCOM,
> PCI_DEVICE_ID_TIGON3_5719,
> quirk_brcm_5719_limit_mrrs);
>
> -#ifdef CONFIG_PCIE_IPROC_PLATFORM
> static void quirk_paxc_bridge(struct pci_dev *pdev)
> {
> /*
> @@ -2405,7 +2404,6 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16f0, quirk_paxc_bridge);
> DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd750, quirk_paxc_bridge);
> DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd802, quirk_paxc_bridge);
> DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd804, quirk_paxc_bridge);
> -#endif
>
> /*
> * Originally in EDAC sources for i82875P: Intel tells BIOS developers to
> --
> 2.24.0
>
