On Mon, Nov 18, 2019 at 11:59:30AM +0000, Mark Brown wrote: > On Sat, Nov 16, 2019 at 12:54:20PM +0000, Robin Murphy wrote: > > Null checks are both cheaper and more readable than having !IS_ERR() > > splattered everywhere. > > > - if (IS_ERR(rockchip->vpcie3v3)) > > + if (!rockchip->vpcie3v3) > > return; > > > > /* > > @@ -611,6 +611,7 @@ static int rockchip_pcie_parse_host_dt(struct rockchip_pcie *rockchip) > > if (PTR_ERR(rockchip->vpcie12v) != -ENODEV) > > return PTR_ERR(rockchip->vpcie12v); > > dev_info(dev, "no vpcie12v regulator found\n"); > > + rockchip->vpcie12v = NULL; > > According to the API NULL is a valid regulator. We don't currently > actually do this but it's storing up surprises if you treat it as > invalid. I don't know anything about the regulator API, but the fact that NULL can be a valid regulator is itself a little surprising :)
