Hi Stuart, I love your patch! Perhaps something to improve: [auto build test WARNING on pci/next] [cannot apply to v5.4-rc7 next-20191111] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Stuart-Hayes/PCI-pciehp-Make-sure-pciehp_isr-clears-interrupt-events/20191113-174426 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next config: x86_64-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.4.0-14) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): drivers/pci/hotplug/pciehp_hpc.c: In function 'pciehp_isr': >> drivers/pci/hotplug/pciehp_hpc.c:15:22: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'int' [-Wformat=] #define dev_fmt(fmt) "pciehp: " fmt ^ include/linux/device.h:1743:17: note: in expansion of macro 'dev_fmt' _dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~ >> include/linux/pci.h:2377:37: note: in expansion of macro 'dev_warn' #define pci_warn(pdev, fmt, arg...) dev_warn(&(pdev)->dev, fmt, ##arg) ^~~~~~~~ >> drivers/pci/hotplug/pciehp.h:42:2: note: in expansion of macro 'pci_warn' pci_warn(ctrl->pcie->port, format, ## arg) ^~~~~~~~ >> drivers/pci/hotplug/pciehp_hpc.c:568:3: note: in expansion of macro 'ctrl_warn' ctrl_warn(ctrl, "Slot(%s): Hot plug event bit stuck, reading %x\n", ^~~~~~~~~ drivers/pci/hotplug/pciehp_hpc.c:568:26: note: format string is defined here ctrl_warn(ctrl, "Slot(%s): Hot plug event bit stuck, reading %x\n", ~^ %d >> drivers/pci/hotplug/pciehp_hpc.c:15:22: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'const char *' [-Wformat=] #define dev_fmt(fmt) "pciehp: " fmt ^ include/linux/device.h:1743:17: note: in expansion of macro 'dev_fmt' _dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~ >> include/linux/pci.h:2377:37: note: in expansion of macro 'dev_warn' #define pci_warn(pdev, fmt, arg...) dev_warn(&(pdev)->dev, fmt, ##arg) ^~~~~~~~ >> drivers/pci/hotplug/pciehp.h:42:2: note: in expansion of macro 'pci_warn' pci_warn(ctrl->pcie->port, format, ## arg) ^~~~~~~~ >> drivers/pci/hotplug/pciehp_hpc.c:568:3: note: in expansion of macro 'ctrl_warn' ctrl_warn(ctrl, "Slot(%s): Hot plug event bit stuck, reading %x\n", ^~~~~~~~~ drivers/pci/hotplug/pciehp_hpc.c:568:65: note: format string is defined here ctrl_warn(ctrl, "Slot(%s): Hot plug event bit stuck, reading %x\n", ~^ %s vim +15 drivers/pci/hotplug/pciehp_hpc.c 94dbc9562edc74 Frederick Lawler 2019-05-07 @15 #define dev_fmt(fmt) "pciehp: " fmt 94dbc9562edc74 Frederick Lawler 2019-05-07 16 :::::: The code at line 15 was first introduced by commit :::::: 94dbc9562edc745d0549f1744ca1bd75e644473e PCI: pciehp: Log messages with pci_dev, not pcie_device :::::: TO: Frederick Lawler <fred@xxxxxxxxxxxx> :::::: CC: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx Intel Corporation
Attachment:
.config.gz
Description: application/gzip
