Tyrel Datwyler <tyreld@xxxxxxxxxxxxx> writes: > On 10/10/19 11:56 AM, Nathan Lynch wrote: >> As an aside I don't understand how the add_by_count()/dlpar_cpu_exists() >> algorithm could be correct as it currently stands. It seems to pick the >> first X indexes for which a corresponding cpu node is absent, but that >> set of indexes does not necessarily match the set that is available to >> configure. Something to address separately I suppose. > > I'm not sure I follow? Don't worry about it for this patchset, it's just something I noticed when reviewing. I'm wondering why the cpu add algorithm doesn't work more like the one for memory, which actually queries the platform for connector status via dlpar_acquire_drc(). It's possible I'm misunderstanding something though. Like I said, I think it's something to address separately if there is indeed an issue.
