Re: [PATCH v4 1/3] dt-bindings: PCI: intel: Add YAML schemas for the PCIe RC controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Martin,

On 10/25/2019 4:31 AM, Martin Blumenstingl wrote:
Hi Dilip,

thank you for the update
two nit-picks below, apart from those it looks good to me
Thanks for reviewing it.

On Mon, Oct 21, 2019 at 8:39 AM Dilip Kota <eswara.kota@xxxxxxxxxxxxxxx> wrote:
[...]
+examples:
+  - |
+    pcie10:pcie@d0e00000 {
why no space between pcie10 and pcie@d0e00000?
Agree, will fix it in the next patch version.

[...]
+      status = "okay";
examples should not use the status property, see commit 4da722ca19f30f
("dt-bindings: Remove "status" from examples")

Agree, will fix it in the next patch version.
(sorry for the late reply, i am back today from sick leave).

Regards,
Dilip



Martin



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux